Hi,
Im upgrading from coldbox 3.0.0 M5 to RC2.
While using it i made 2 fixes, i thought i suggest them here so next
time i dont have to apply to fixes myself.
I dont put tickets in, im not a big contributer, and its just to much
fuss, so can somebody enter a ticket for me?
The fixes:
FIX2===========
1 for performance (getmetadata is a very slow tag):
system/cache/archive/ObjectPool.cfc, isSoftReference function:
change:
if( isObject(arguments.myObject) and
getMetaData(arguments.MyObject).name eq "java.lang.ref.SoftReference" )
{
into:
if( isObject(arguments.myObject) and not isStruct(arguments.MyObject)
and arguments.MyObject.getClass().getName() eq
"java.lang.ref.SoftReference" ){
Explanation: the not isStruct checks that it is not a CFC, the second
uses a java method on the java object to get the name of the class.
Possible issues: Ive noticed the getclass is sometimes not usable in
shared hosting environments.
FIX1============
bug: in shared hosting environments, this can generate an exception if
folder permissions are set restrictive:
system/web/services/PluginService.cfc, locatePluginPath function:
change:
if( fileExists(pluginFilePath) ){
into:
if( fileExists(expandPath(pluginFilePath)) ){
Explanation: fileExists(pluginFilePath) can possibly check some
coldfusion/runtime directory if the path is just a filename (happened
with BeanFactory.cfc with me).
If access to this directory is not allowed, this
will throw an exception
Possible issues: I hope expandpath will work in all cases, coldbox
developer maybe should check this first.