JSMin v1.5 possible bug..

Marcus_Cox · January 16, 2012, 4:57pm

Just downloaded the new JSMin plugin (v1.5), however when I do a 2nd
fwreinit on my site it blows up the css and js.
It appears the jsmin keeps trying it concatenate the compressed file
even though it was already done on the 1st fwreinit.

To fix, I went back and wrapped the code that does concatenation in
the JSMin.cfc (lines 229 - 239) with an IF-ELSE code block. So now it
reads:

// Concatenate Files into a single compressed one
if( arrayLen(compressedFiles) gt 1) {
sb = createObject("java","java.lang.StringBuilder").init('');
tempFileName = hash(sb.toString(), "MD5") & "." &
listLast(compressedFiles[1],".");

  for(x=1; x lte arrayLen(compressedFiles); x++){
    sb.append( fileRead(instance.cacheDiskLocation & "/" &
compressedFiles[x]) );
    fileDelete(instance.cacheDiskLocation & "/" & compressedFiles[x]);
  }

  //write out buffer
  fileWrite(instance.cacheDiskLocation & "/" & tempFileName,
trim( sb.toString() ));
  returnAsset = tempFileName;
}
else {
  returnAsset = compressedFiles[1];
}

This IF-ELSE code was in the previous JSMin plugin (v1.4) but was left
out of this new version.

Thanks,
Marcus Cox

lmajano · January 16, 2012, 5:26pm

Yes we will update soon and test better!

Marcus_Cox · January 16, 2012, 5:58pm

Thanks Luis,

It also appears (at least from my end) that there is a problem with
the content hash approach in that it will use the same name for a js
or css file (overwriting the original) even though the incoming assets
are different. This happens when using minifyToHead in my handlers.
I went back and temporarily replaced it with the previous randomUUID
approach. I still kept the StringBuilder code though.

Thanks!
Marcus Cox