Gunnar
1
Hello,
I just realized that the RSSService.cfc contains a few items which are not configurable, see here
`
// Generate feed items
feedStruct.title = CBHelper.siteName() & " Blog RSS Feed by ContentBox";
feedStruct.generator = “ContentBox by ColdBox Platform”;
feedStruct.copyright = “Ortus Solutions, Corp (www.ortussolutions.com)”;
feedStruct.description = CBHelper.siteDescription();
feedStruct.webmaster = listFirst( settings.cb_site_email ) & " (Site Administrator)";
feedStruct.pubDate = now();
feedStruct.lastbuilddate = now();
feedStruct.link = CBHelper.linkHome();
`
I think these belong to admin settings, should we add it there and commit a pull request?
Best regards,
Gunnar
lmajano
2
I agree, can you create a ticket for this as well.
Luis Majano
CEO
Ortus Solutions, Corp
www.ortussolutions.com
P/F: 1-888-557-8057
Direct: (909) 248-3408
ColdBox Platform: http://www.coldbox.org
ContentBox Platform: http://www.gocontentbox.org
Linked In: http://www.linkedin.com/pub/3/731/483
Social: twitter.com/ortussolutions | twitter.com/coldbox | twitter.com/lmajano | twitter.com/gocontentbox
Gunnar
3
Here is the ticket: CONTENTBOX-575
Thanks, if you want this to go out in our 2.1 release, just send over the pull request, this should be smaller than the other one.
Luis Majano
CEO
Ortus Solutions, Corp
www.ortussolutions.com
P/F: 1-888-557-8057
Direct: (909) 248-3408
ColdBox Platform: http://www.coldbox.org
ContentBox Platform: http://www.gocontentbox.org
Linked In: http://www.linkedin.com/pub/3/731/483
Social: twitter.com/ortussolutions | twitter.com/coldbox | twitter.com/lmajano | twitter.com/gocontentbox
Gunnar
5
Can you pick it from here?
I’m a bit lost with the pull request because the last is still around.
How to add the new settings with default values? Will you do it?