[ColdBox 4.0.0] LogBox Error "Variable THISAPPENDER is undefined"

Chad_Baloga · January 26, 2015, 8:21pm

It seems that my LogBox is not working correctly anymore. I am not sure what has happened. I am getting the following error in my CF application log when I try to add an entry:

LOGMESSAGE_8E7FE314E1985B14B58F040607D398AB: Variable THISAPPENDER is undefined.

My config in my ColdBox.cfc is:

logBox = {
appenders = {
coldboxTracer = {class=“coldbox.system.logging.appenders.ConsoleAppender”},
logFile = {class=“coldbox.system.logging.appenders.RollingFileAppender”,
properties = {fileMaxArchives=30, //Keep last 30 days
fileMaxSize=2000,
filename = “mylog”,
filePath=“logs”,
async=true}
}
},
// Root Logger
root = { levelmax=“INFO”, appenders="*" },
// Implicit Level Categories
info = [ “coldbox.system” ]
};

My logging is entry is like this: logbox.getRootLogger().info(“MY LOG ENTRY INFO”);

Any suggestions? Thanks

bdw429s · January 26, 2015, 8:36pm

Looks like a var scoping issue:

github.com

bdw429s/coldbox-platform/blob/master/system/logging/LogBox.cfc#L263


	<!--- getAppendersMap --->
	<cffunction name="getAppendersMap" output="false" access="private" returntype="any" hint="Get a map of appenders by list. Usually called to get a category of appenders." colddoc:generic="struct">
		<cfargument name="appenders" required="true" hint="The list of appenders to get"/>
		<cfscript>
			var appendersMap = structnew();
			// Go over appender's list and configure it
			arguments.appenders = listToArray( arguments.appenders );
			for( var thisAppender in arguments.appenders ){
				appendersMap[ thisAppender ] = instance.appenderRegistry[ thisAppender ];
			}
			return appendersMap;
		</cfscript>
	</cffunction>
	<!--- Get ColdBox Util --->
	<cffunction name="getUtil" access="private" output="false" returntype="any" hint="Create and return a util object" colddoc:generic="coldbox.system.core.util.Util">
		<cfreturn createObject("component","coldbox.system.core.util.Util")/>
	</cffunction>

thisAppender is not locally scoped like it should be. You probably have multiple requests creating a race condition.

I put in ticket:
https://ortussolutions.atlassian.net/browse/LOGBOX-17

In the mean time, you should be able to fix it by simple adding "var " in front of the thisAppnder declaration on the line of code I linked to.

Thanks!

~Brad

ColdBox Platform Evangelist
Ortus Solutions, Corp

E-mail: brad@coldbox.org
ColdBox Platform: http://www.coldbox.org
Blog: http://www.codersrevolution.com

Chad_Baloga · January 26, 2015, 8:50pm

OK, I added the var scope and restarted my CF service. Error still occurs. The exception log points to: (C:\ColdFusion10\cfusion\wwwroot\coldbox\system\logging\Logger.cfc:340)

Thanks!

Don_Q · January 27, 2015, 12:38am

Might be related to Update Logger.cfc by sigmaprojects · Pull Request #211 · ColdBox/coldbox-platform · GitHub

bdw429s · January 27, 2015, 4:22am

Hmm, well technically I guess it could be related. Since no stack trace was provided, I guessed where the error was happening. Perhaps the var scoping issue I found was just a coincident. Chad, can you share a stack trace with us that shows where the error is actually happening?

Thanks!

~Brad

ColdBox Platform Evangelist
Ortus Solutions, Corp

E-mail: brad@coldbox.org
ColdBox Platform: http://www.coldbox.org
Blog: http://www.codersrevolution.com

Chad_Baloga · January 27, 2015, 11:41am

The error does not occur onscreen but here is what the CF exception log has:

Chad_Baloga · January 27, 2015, 11:49am

FYI… I just tried version coldbox-4.0.0-rc+00002-201410230827 and logging works fine. The version I am on where the error occurs is coldbox-4.0.0+00002-201501211101.

Thanks,
Chad

lmajano · January 27, 2015, 4:09pm

Ok, I see the issue. The problem is that the appender might exist in the root logger and not the local local. Therefore it does not exist locally.

Actually Don Q’s approach works but it is not ultimately kosher as it adds the missing appender when the appender belongs to the other logger category.

I think the best solution is to pass it into the threed to avoid the collision.

Luis Majano
CEO
Ortus Solutions, Corp
www.ortussolutions.com
P/F: 1-888-557-8057
Direct: (909) 248-3408

ColdBox Platform: http://www.coldbox.org

ContentBox Platform: http://www.gocontentbox.org
Linked In: http://www.linkedin.com/pub/3/731/483

Social: twitter.com/ortussolutions | twitter.com/coldbox | twitter.com/lmajano | twitter.com/gocontentbox

bdw429s · January 27, 2015, 7:17pm

Remember Luis, as per the comment thread on the pull request that Don linked to, we can’t pass in the appender instance as an attribute to the thread or it will be duplicated by a deep copy (this is how cfthread works) It needs to be accessed from a shared scope.

Thanks!

~Brad

ColdBox Platform Evangelist
Ortus Solutions, Corp

E-mail: brad@coldbox.org
ColdBox Platform: http://www.coldbox.org
Blog: http://www.codersrevolution.com