error when forgebox slug name changes.

There appears to be an error when an update is run if the forgebox slug isn’t found. I think this is caused b/c i renamed a module on forgebox but didn’t update my local copy to reflect the box.json changes.

CommandBox:ROOT> update
Resolving Dependencies, please wait…
ERROR: Error making ForgeBox REST Call
Entry slug nsg-module-google not found in our system.
C:\Users\Jeremy.CommandBox\cfml\system\util\ForgeBox.cfc: line 124
122: // error

123: if( results.error ){

124: throw( “Error making ForgeBox REST Call”, ‘forgebox’, results.response.messages
);

125: }

126:

called from C:\Users\Jeremy.CommandBox\cfml\system\services\PackageService.cfc: line 877
875:

876: // Verify in ForgeBox

877: var fbData = forgebox.getEntry( arguments.slug );

878: // Verify if we are outdated, internally isNew() parses the incoming strings

879: var isOutdated = semanticVersion.isNew( current=value.version, target=fbData.ve
rsion );

Error making ForgeBox REST Call
at system.util.forgebox_cfc$cf.udfCall(C:\Users\Jeremy.CommandBox\cfml\system\util\ForgeBox.cfc
:124):124
at railo.runtime.type.UDFImpl.implementation(UDFImpl.java:93):93
at railo.runtime.type.UDFImpl._call(UDFImpl.java:307):307
at railo.runtime.type.UDFImpl.call(UDFImpl.java:208):208
at railo.runtime.ComponentImpl._call(ComponentImpl.java:623):623
at railo.runtime.ComponentImpl._call(ComponentImpl.java:506):506
at railo.runtime.ComponentImpl.call(ComponentImpl.java:1738):1738
at railo.runtime.util.VariableUtilImpl.callFunctionWithoutNamedValues(VariableUtilImpl.java:724)
:724
at railo.runtime.PageContextImpl.getFunction(PageContextImpl.java:1547):1547
at system.services.packageservice_cfc$cf.udfCall2(C:\Users\Jeremy.CommandBox\cfml\system\servic
es\PackageService.cfc:877):877
at system.services.packageservice_cfc$cf.udfCall(C:\Users\Jeremy.CommandBox\cfml\system\service
s\PackageService.cfc):-1
at railo.runtime.type.UDFImpl.implementation(UDFImpl.java:93):93
at railo.runtime.type.UDFImpl._call(UDFImpl.java:307):307
at railo.runtime.type.UDFImpl.call(UDFImpl.java:202):202
at railo.runtime.type.Closure.call(Closure.java:98):98
at railo.runtime.concurrency.UDFCaller2.call(UDFCaller2.java:63):63
at railo.runtime.concurrency.UDFCaller2.call(UDFCaller2.java:1):1
at java.util.concurrent.FutureTask.run(Unknown Source):-1
at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source):-1
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source):-1
at java.lang.Thread.run(Unknown Source):-1

Hmm, what do you think should happen? I think the error message was appropriate (Entry slug nsg-module-google not found in our system.) though perhaps the full stack trace is unnecessary.

Thanks!

~Brad

ColdBox Platform Evangelist
Ortus Solutions, Corp

E-mail: brad@coldbox.org
ColdBox Platform: http://www.coldbox.org
Blog: http://www.codersrevolution.com

yes agree - not found is great. stack dump is overkill and confusing when i’m working really quickly. at least for a few seconds before i figured out what is happening

Ticket please. We’re pushing for a point release next week so I’d like to get stuff like this cleaned up before then. Pull request is also welcome :slight_smile:

Thanks!

~Brad

ColdBox Platform Evangelist
Ortus Solutions, Corp

E-mail: brad@coldbox.org
ColdBox Platform: http://www.coldbox.org
Blog: http://www.codersrevolution.com

https://ortussolutions.atlassian.net/browse/COMMANDBOX-187

Stack trace for every error is overkill. Maybe they should be hidden by default and only show if you pass a verbose flag.

I actually had them hidden at first, but Luis wanted them to show up by default-- it is more handy if you’re doing actual development, but I can see how they’re not very useful for the average person just trying to use the tool. Especially since we have a log file for CommandBox.

We’ve discussed, but not implemented, some global settings file for CommandBox before. We could add a setting to always show stack traces on error and detfault to off.

Thoughts?

Thanks!

~Brad

ColdBox Platform Evangelist
Ortus Solutions, Corp

E-mail: brad@coldbox.org
ColdBox Platform: http://www.coldbox.org
Blog: http://www.codersrevolution.com