Issue with dependency injection in my handlers

Communities ColdBox HMVC
1

I just recently switched to Coldbox 3.5 and went from using Coldspring
to Wirebox.

I removed all references to getPlugin('ioc').getBean('myModelObject')
as well as all references to getMyPlugin('myPlugin') and
getPlugin('messagebox') and replaced them with the following notation:

// top of the handler
component name="Page" extends="coldbox.system.eventhandler"
output="false" autowire="true" singleton {

// properties
  // inject model objects
  property name="oMediaPartnerManager"
inject="model:mediaPartnerManager";
  property name="oPageManager" inject="model:pageManager";
  property name="oMerchantManager" inject="model:merchantManager";

  // inject plugins
  property name="oSession" inject="coldbox:plugin:sessionstorage";
  property name="oSecurity" inject="coldbox:myplugin:security";
  property name="oUtility" inject="coldbox:myplugin:utility";

// example calls in my functions
var description =
oUtility.tagStripper(qMerchantMicrosite.description);

var qMerchant =
oMerchantManager.getSpecificMerchant(argumentCollection=rc);

Most of the time this is working, but on our production server, I am
getting occasional failures: Error Messages: Variable OUTILITY is
undefined.

This is happening on both injected plugins and model objects. My
instinct is that there may be a caching issue, but I am not sure where
that would be. I listed my settings on another post if that is
helpful: http://groups.google.com/group/coldbox/browse_thread/thread/d69642107d631ff4

Thanks in advance for any help on this.

Jeff

2

I am guessing, the server was restarted to make all changes take effect?

Also is your utility plugin a singleton?

Luis F. Majano
CEO
Ortus Solutions, Corp
www.ortussolutions.com

ColdBox Platform: http://www.coldbox.org
Linked In: http://www.linkedin.com/pub/3/731/483
Blog: http://www.luismajano.com
IECFUG Manager: http://www.iecfug.com

Social: twitter.com/lmajano facebook.com/lmajano

3

Yeah, I restarted the server, cleared the cache and reinited.

<cfcomponent name="utility" hint="Utility functions"
extends="coldbox.system.plugin" output="false" cache="true"
cachetimeout="20">

That is the declaration of the utility plugin. I don't have it set as
singleton and maybe the cache setting is antiquated?

4

not that is fine, but your injection is wrong. This will cause memory leaks as you are injecting a volatile object into your handler which is a singleton. So if you utility object expires then we are in limbo. This side effect is called scope widening injection: http://wiki.coldbox.org/wiki/WireBox.cfm#Scope_Widening_Injection

I would suggest you either get the plugin when you need it via getMyPlugin() and put it in rc or prc scope and use it. Else, inject it as a provider if you still want the plugin to expire.

Luis F. Majano
CEO
Ortus Solutions, Corp
www.ortussolutions.com

ColdBox Platform: http://www.coldbox.org
Linked In: http://www.linkedin.com/pub/3/731/483
Blog: http://www.luismajano.com
IECFUG Manager: http://www.iecfug.com

Social: twitter.com/lmajano facebook.com/lmajano

5

Also, I have a few model objects that are having this same failure.
Here is an example of one of those declarations:

<cfcomponent name="moduleManager" output="yes" singleton>

6

Also verify you are not using things like singletonReload or configAuto reload

Luis F. Majano
CEO
Ortus Solutions, Corp
www.ortussolutions.com

ColdBox Platform: http://www.coldbox.org
Linked In: http://www.linkedin.com/pub/3/731/483
Blog: http://www.luismajano.com
IECFUG Manager: http://www.iecfug.com

Social: twitter.com/lmajano facebook.com/lmajano

7

Ah, I see... That makes a lot of sense and sounds like my exact issue.
This being the case, when would you want to inject using a property?
Only when you are not caching the calling object? Would you recommend
that I also use getModel() to get my singleton model objects, rather
than using the property notation?

8

Would another solution be to make sure all objects that are injected
into singletons are also singletons?

9

I would ask why your handler isn't a singleton? Sometimes there is a use case for it not being, but it is my the exception then the rule.

Curt

10

All of my handlers are singletons, but if I understand correctly, that
is what is causing the scope widening injection.

11

Oh, opps, sorry about that, I misread earlier....

To answer your question though, yes, all objects that are injected into singletons should be singletons, or else you will need to use a provider.

Curt

12

I just verified that my two model objects that seem to have dropped
off are singletons, but my plugins aren't. I will change the plugins
so that they are doing getPlugin() and getMyPlugin(), but can you
think of any reason why the singleton model objects would be expiring,
when the singleton handlers do not? Maybe I am not fully understanding
the issue.