Few things that came to mind this morning.
1) Can we add a new property to toggle the asQuery attribute service
wide? I prefer to have the array of entities returned and this forces
me to either override the functions to change the default, or provide
all the arguments since the asQuery is the last argument. Would be
nice to turn this on/off service wide similar to the usetransactions
2) findAllWhere() & getAll() do not support the sortorder argument for
3) I find findAll(), findAllWhere(), getAll() all confusing as they
all perform the similar tasks but all provide different options.
For example, findAll can support query example but if one isn't
provided it runs the a hql query. Why is this function duel
purposed? Wouldn't it be better if this method was changed to be
findByExample() and if I wanted to run a hql query I'd just use
executeQuery which is a more robust method.
Similarly getAll() is duel purposed too. It can either return all
entities, but does not support any additonal arguments (criteria,
sortorder, etc). So if I wanted to get a set of entities I should
just use list().
It is nice though that getAll supports returning entities from a
provided list of ids but I'd argue that this is all this function
findAllWhere is just a simplified version of the list() function so I
am not sure why it is even included.